zopefoundation / roman

Integer to Roman numerals converter
Other
45 stars 10 forks source link

add `is_roman_numeral` func #14

Closed AndrewBasem1 closed 1 year ago

AndrewBasem1 commented 1 year ago

Additions

Adding is_roman_numeral function to roman.py file

Why?

This is a helpful function that can be used to check if an input string is a valid roman numeral or not ^_^

AndrewBasem1 commented 1 year ago

I realize this still needs to accomdate the CLI args, just pushing the simplest commit to check if you are open to PRs or not

dataflake commented 1 year ago

This project is open to PRs, but there's a few issues:

AndrewBasem1 commented 1 year ago

@dataflake thank you for reviewing my PR, Please check the following changes:

  1. fixed linting errors → please rerun the checks again
  2. Added changes to Changes.txt → please review the edit to that file

regarding the unit tests, can you offer some assist on how to start on those? haven't done them before ^_^ I'll sign the agreement later before merging as I don't have access to a printer right now

Thank you

dataflake commented 1 year ago

@AndrewBasem1 The tests will run automatically whenever you make a push. The linting tests are still failing.

You can add test methods to the test class TestRoman in the tests.py module. The existing tests should make it clear how you call the method or function you want to test with various argument values and then test the return value with the different assert methods.

icemac commented 1 year ago

Are there any news for this PR otherwise I'd like to close it if there is no interest or steam to complete it.