zopefoundation / transaction

Generic transaction implementation for Python.
Other
70 stars 31 forks source link

Hate bytes #32

Closed jimfulton closed 7 years ago

jimfulton commented 8 years ago

Insist that transaction user and description are text (unicode)

See: https://groups.google.com/forum/#!topic/zodb/U0H1kTh_dY4

There will be much breakage because of this for Python 2.7 applications. I had to fix quite a few ZODB tests, although that may not be a great indicator.

jimfulton commented 8 years ago

Julien, feel free to ignore this, but I wanted to at least invite you to the loop. :)

jimfulton commented 8 years ago

Waaaaa, the doc tests. We'll at least travis is running them now, cuz I forgot. :)

jimfulton commented 7 years ago

OK, I implemented the suggestions and fixed the doctest.

jamadden commented 7 years ago

Oh, should there be a change note?

jimfulton commented 7 years ago

Yup :)

jimfulton commented 7 years ago

@tseaver do you want to weigh in? If not, that's OK.