search

zopefoundation / transaction

Generic transaction implementation for Python.
Other
70 stars 31 forks source link

In WeakSet, use the `valuerefs` method from Python 2.5 instead of accessing the internal `data` implementation detail. #8

Closed jamadden closed 9 years ago

jamadden commented 9 years ago

This lets us support Jython. Unfortunately, 'tox' doesn't currently work with Jython. I tried to set up travis to work with Jython as described at https://www.topbug.net/blog/2012/05/27/use-travis-ci-with-jython/ (referenced from http://docs.travis-ci.com/user/resources/).

mgedmin commented 9 years ago

The Travis configuration hack makes me sad :(

jamadden commented 9 years ago

I agree it's not pretty, but Travis doesn't seem to explicitly support jython. I'd be happy to try any other ideas.

tseaver commented 9 years ago

-1 for fighting w/ Travis: just leave jython out there.

jamadden commented 9 years ago

@tseaver I'm sorry, I'm having a hard time parsing your sentence. Are you saying you don't want travis to run tests on jython? If that's the case, then should I also remove the classifier from setup.py?

tseaver commented 9 years ago

I'm saying that until Travis supports jython natively, I'm not interested in trying to end-run it: the extra time to install jython every time the tests run is definitely not worth it.

OTOH, if tox -e jython works w/ 2.7rc2, I'm OK with leaving the Trove classifier in, in spite of Travis.

jamadden commented 9 years ago

Sadly, tox -e jython is currently broken. I submitted a bug report, hopefully it will get fixed before the final release.

jamadden commented 9 years ago

The Jython bug was fixed in rc3, but tox itself still won't run due to an issue conflicting with virtualenv.

Moving away from the non-standard data attribute makes sense to me in any case though.

tseaver commented 9 years ago

Thank you!

tseaver commented 9 years ago

Released via https://pypi.python.org/pypi/transaction/1.4.4.