search

zopefoundation / z3c.checkversions

Find newer package versions on PyPI
Other
2 stars 6 forks source link

Fix index url installed packages (part 2) #19

Closed janjaapdriessen closed 4 years ago

janjaapdriessen commented 4 years ago

I merged #18 to master. I tried to upload to pypi using zest.releaser, to find out I made a mistake in the setup.py metadata, which I tried to fix on master with a brown-paper-bag-release. I am not allowed to commit to master (for all the right reasons):

remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: At least 1 approving review is required by reviewers with write access.

I revived the branch and did the tag + upload to pypi from this branch. Would you please review these changes?

mgedmin commented 4 years ago

I've removed the branch protection because it totally breaks the zest.releaser workflow (which requires the person doing the upload to push the "release version X" and the "post-release version bump" commits directly to master) even when nothing goes wrong during the release.

icemac commented 4 years ago

@mgedmin At least I'd like to keep prevention of force pushes to master and deletion of the master branch provided by branch protection without any other requirements. Are you okay with this?

mgedmin commented 4 years ago

Yes, +:100: for disallowing forced pushes and deletion.

mgedmin commented 4 years ago

(Looks like I got confused by the UI and didn't realize that deleting the master protection rule would start allowing those actions. I've now added it back, with no checkboxes checked, which matches the configuration of zope.interface.)