search

zopefoundation / z3c.form

An advanced form and widget framework for Zope 3
Other
9 stars 39 forks source link

ISubformFactory -> unused code? #110

Closed petschki closed 2 years ago

petschki commented 2 years ago

While updating Plone to the latest z3c.form I came across this Interface:

https://github.com/zopefoundation/z3c.form/blob/7f204a61571003dfdf382621ffd601c2ef503dc8/src/z3c/form/interfaces.py#L370-L378

Is this interface still used somewhere or is this a leftover from the SubFormObject refactoring? I'm asking, because we might need to backport this SubformFactory to plone.z3cform and I don't want to rely on unused code.

icemac commented 2 years ago

Probably it is a leftover from removing SubFormObject. Feel free to create a PR to remove that interface.

icemac commented 2 years ago

The adapter implementing this interface was removed here: https://github.com/zopefoundation/z3c.form/commit/4f3a611ac23beb1c1ca1993cd98e42dc333afffc#diff-84025a2d96cba5fdbf200d61a4e87b1f2e1495999cfef5615ef87ecfae146f18L353