search

zopefoundation / z3c.form

An advanced form and widget framework for Zope 3
Other
9 stars 39 forks source link

Don't set the boolean required attribute as required. #118

Open thet opened 1 year ago

thet commented 1 year ago

Boolean attributes with a default value which do not have to be set to true should not be marked as required attributes.

d-maurer commented 1 year ago

Johannes Raggam wrote at 2023-7-17 00:43 -0700:

Boolean attributes with a default value which do not have to be set to true should not be marked as required attributes.

Someone has made a similar change some time ago (maybe 1 year) and reverted his change because it has caused many problems with existing applications.

You should be careful to avoid that your change does the same.

petschki commented 1 year ago

IIRC this was the PR which reverted the Bool required=False https://github.com/zopefoundation/zope.schema/pull/107

petschki commented 1 year ago

And this issue https://github.com/zopefoundation/zope.schema/issues/104