search

zopefoundation / z3c.form

An advanced form and widget framework for Zope 3
Other
8 stars 39 forks source link

headsup for MAJOR overhaul of ObjectWidget PR #40

Closed agroszer closed 8 years ago

agroszer commented 8 years ago

see #38

please review or comment when noone objects will merge in a week

Martronic-SA commented 8 years ago

collective.z3cform.datagridfield is broken by that commit. I don't know if it will be possible to fix with thoses changes.. ?

agroszer commented 8 years ago

Sorry, ObjectWidget was PITA. You could pin z3c.form at a version that's compatible with collective.z3cform.datagridfield

thet commented 8 years ago

Shouldn't the general zopefoundation code review rules - getting review from another person - also apply to z3c.form?

Your self-merged changes for z3c.form 3.3.0 (should actually be a 4.0 release) introduces hard-to-resolve incompatibilities with Plone. And Plone is probably the biggest consumer of this project.

/cc @mgedmin @tseaver @esteele