search

zopefoundation / z3c.form

An advanced form and widget framework for Zope 3
Other
8 stars 39 forks source link

[WIP] Fix default value of a collection when available items comes from a source #58

Closed tdesvenain closed 3 years ago

tdesvenain commented 7 years ago

refs issue #59

tdesvenain commented 7 years ago

Hi, before cleaning up this implementation and adding tests, i'd like to get your opinion about the way i fix the issue.

icemac commented 7 years ago

@tdesvenain Sorry, I do not understand the problem. Maybe a test could show what you want to achieve. (BTW I am using sources instead of vocabularies all the time.)

icemac commented 7 years ago

@tdesvenain What is the current status of this PR?

tdesvenain commented 7 years ago

I have to write the unit tests

icemac commented 7 years ago

@tdesvenain wrote:

I have to write the unit tests

Okay, nice. Please ask if you have questions about the tests.

icemac commented 7 years ago

@tdesvenain Could you please rebase on master, too, so we get coverage measurement for this PR.

icemac commented 6 years ago

@tdesvenain I redirected the PR to the new 3.x branch, as I closed 3.2.x in favour of it.

icemac commented 4 years ago

Is this PR still valid or should we close it?