Deal with items with same name but different values in ordered field widget - Githubissues

zopefoundation / z3c.form

An advanced form and widget framework for Zope 3

Other

9 stars 39 forks source link

Deal with items with same name but different values in ordered field widget #76

Closed rodfersou closed 5 years ago

rodfersou commented 6 years ago

fix #75

rodfersou commented 6 years ago

@hvelarde FYI

icemac commented 6 years ago

@rodfersou Thank you for your PR. Could you please add a test which assures the changed behaviour?

rodfersou commented 6 years ago

@hvelarde done @icemac can you please point me an widget test example?

There is no test for this widget in this package.

icemac commented 6 years ago

@rodfersou The OrderedSelectWidget is tested in this doctest: z3c/form/browser/orderedselect.rst. Maybe you could use some of the code in this file to create a new unittest as the doctest also serves as documentation and should not contain too many edge case tests.

rodfersou commented 6 years ago

@icemac I am having some trouble to finish this PR https://github.com/zopefoundation/z3c.form/issues/78

rodfersou commented 5 years ago

@icemac I think this change in test is sufficient, please take a look

rodfersou commented 5 years ago

looks like I break something.. that's weird..

rodfersou commented 5 years ago

@icemac did you see my changes?

icemac commented 5 years ago

@rodfersou Did you already sign the Zope Committer Agreement? It will allow you to merge the PR on your own. (That's the policy in the zopefoundation repositories.)

rodfersou commented 5 years ago

@icemac no, I didn't.. just the Plone Agreement

rodfersou commented 5 years ago

@icemac signed and sent the email :-)

rodfersou commented 5 years ago

@icemac a release would be appreciated

icemac commented 5 years ago

@rodfersou Currently the tests are failing on master, see https://travis-ci.org/zopefoundation/z3c.form/jobs/436732823. Are you willing to look into these failures. I think they have to do with new releases of e. g. zope.schema.

rodfersou commented 5 years ago

@icemac wow! last month they did 6 releases at zope.schema! can someone guide me on what is going on?

jamadden commented 5 years ago

I looked over the test output. Everything looks cosmetic, and all related to raising more specific exceptions with different error messages than before (from both zope.schema and zope.configuration). That's great for code when you can except SomethingSpecific as ex and access attributes of ex that provide you with actionable information, but it does expose the fragility of doctests like this.

rodfersou commented 5 years ago

davisagli commented 5 years ago

I did some work on fixing the tests for the 3.x branch which can probably be easily merged to master: https://github.com/zopefoundation/z3c.form/commit/4421dc42d1f453f0dc6c976dc0aba4dfba69fc79

rodfersou commented 5 years ago

great!