start py3 support - Githubissues

mgedmin commented 6 years ago

Travis CI decided for some reason that this repository was not active. I activated it and triggered a custom build for this branch.

mgedmin commented 6 years ago

Looks like the good old buildout-trying-to-restart-itself-recursively-in-an-infinite loop bug.

Also, it looks like you haven't added multiple Python versions to .travis.yml yet? There's only one build job on Travis.

Usually I recommend the following for Python 3 porting PRs:

[x] a tox.ini so testing multiple Pythons is easier locally
[x] a .travis.yml for the same set of supported Python versions
[x] setup.py classifiers for the set of supported Python versions
[x] a CHANGES.rst entry listing updates of set of supported Python versions (e.g. "added support for 3.4, 3.5, 3.6, 3.7; dropped support for 2.6" etc.)
[ ] (if the package has appveyor builds for testing on Windows) make sure appveyor.yml lists the same supported Python versions
[ ] (if a package builds binary manylinux wheels) making sure the wheels are built for the same set of supported Python versions

jensens commented 6 years ago

Now things are cleaned up. Anythings missing?

mgedmin commented 6 years ago

:sparkle: :100: :sparkle:

zopefoundation / z3c.jbot