search

zopefoundation / zodbpickle

Fork of Python's pickle module to work with ZODB
Other
17 stars 15 forks source link

Configuring for c-code #88

Closed tseaver closed 4 months ago

tseaver commented 4 months ago

@dataflake, @icemac Any idea about the skipped-but-required tests here?

I could just remove them from the branch protection, but maybe there is policy for applying such changes uniformly across the organization?

dataflake commented 4 months ago

I have fixed those manually usually. When you run the configure script there's a step at the end that does this, though.

icemac commented 4 months ago

I have fixed those manually usually. When you run the configure script there's a step at the end that does this, though.

Even though this script might have a bug: It should keep the setting of required code reviews for pull requests but seems to set them always. – I think we did not have a discussion for which packages (or even all) code reviews should be required.

dataflake commented 4 months ago

IMHO the setting of "always require reviews, but these groups (owners, managers, release managers) are exempt" is good for all packages.