search

zopefoundation / zodbpickle

Fork of Python's pickle module to work with ZODB
Other
17 stars 15 forks source link

'PURE_PYTHON=1' ignored during build #93

Closed tseaver closed 2 months ago

tseaver commented 3 months ago

The C extension gets built willy-nilly. This is after removing usedevelop = true from tox.ini (see https://github.com/zopefoundation/meta/pull/257):

$ ll .tox/py38-pure/lib/python3.8/site-packages/zodbpickle/
total 964
drwxrwxr-x  4 tseaver tseaver   4096 Jun 27 17:21 ./
drwxrwxr-x 17 tseaver tseaver   4096 Jun 27 17:21 ../
-rw-rw-r--  1 tseaver tseaver    891 Jun 27 17:21 fastpickle.py
-rw-rw-r--  1 tseaver tseaver     44 Jun 27 17:21 __init__.py
-rw-rw-r--  1 tseaver tseaver 205193 Jun 27 17:21 _pickle_33.c
-rw-rw-r--  1 tseaver tseaver  52163 Jun 27 17:21 pickle_3.py
-rwxrwxr-x  1 tseaver tseaver 598232 Jun 27 17:21 _pickle.cpython-38-x86_64-linux-gnu.so*
-rw-rw-r--  1 tseaver tseaver     24 Jun 27 17:21 pickle.py
-rw-rw-r--  1 tseaver tseaver  87531 Jun 27 17:21 pickletools_3.py
drwxrwxr-x  2 tseaver tseaver   4096 Jun 27 17:21 __pycache__/
-rw-rw-r--  1 tseaver tseaver   1061 Jun 27 17:21 slowpickle.py
drwxrwxr-x  3 tseaver tseaver   4096 Jun 27 17:21 tests/

Note that we have tests which rely on this (undesirable) behavior.