search

zopefoundation / zope.app.form

The Original Zope 3 Form Framework
Other
0 stars 4 forks source link

Add Python 3.4/5/6 and PyPy support. #1

Closed jamadden closed 7 years ago

jamadden commented 7 years ago

Coverage isn't perfect but its pretty good.

This blocks zope.app.rotterdam, which blocks zope.app.component.

Test coverage isn't 100% but it's pretty good at 97%.

There was actually almost nothing to do here aside from implements to implementer and a few doctest cleanups.

I did discover a bug in zope.configuration.fields.MessageID but the workaround was easy and not terribly ugly.

jamadden commented 7 years ago

I was actually able to get zope.app.rotterdam to work independent of this; it's not needed for anything other than interfaces and doesn't have to be configured for the tests to work. See zopefoundation/zope.app.rotterdam#1.

jamadden commented 7 years ago

The MessageID bug has been fixed. Do we want to wait for a new zope.configuration and code a dependency on that version, or still have a workaround but leave the zope.configuration version unpinned?

jamadden commented 7 years ago

I think I've addressed all the comments, and the two bugs we had workarounds for have been fixed, released, and workarounds removed. Since there are two approvals, I'll go ahead and merge. Thanks everyone!

Could we please get a PyPI release when convenient?

mgedmin commented 7 years ago

You now have PyPI rights.

jamadden commented 7 years ago

Thanks! Released to PyPI.