search

zopefoundation / zope.configuration

Extensible system for supporting various kinds of configurations
https://zopeconfiguration.readthedocs.io
Other
1 stars 6 forks source link

Python3 support for printing ConfigurationConflictError #14

Closed janjaapdriessen closed 7 years ago

mgedmin commented 7 years ago

LGTM

jamadden commented 7 years ago

I'm surprised that made it this long. That suggests it's not covered by a unit test. Would this be a good time to add one?

janjaapdriessen commented 7 years ago

Added a test in test_configuration_conflict_error_has_readable_exception. Apologies about removing the whitespace cluttering the diff, my editor eats them.

janjaapdriessen commented 7 years ago

@jamadden @mgedmin is this PR to your satisfaction?

jamadden commented 7 years ago

LGTM, thanks for the test! (No worries about the whitespace, my editor does the same thing. It's easy to ignore by tacking?w=0 onto the end of the URL.)