search

zopefoundation / zope.index

Indices for using with catalog like text, field, etc.
Other
10 stars 12 forks source link

python3.7 builds for linux, mac, and windows #20

Closed fgregg closed 5 years ago

fgregg commented 6 years ago

This PR directs appveyor and travis to build wheels for python 3.7

jamadden commented 6 years ago

There seem to be some true 3.7 compatibility issues here, having to do with pep 479 as implemented in 3.7

fgregg commented 6 years ago

@jamadden I might take a swing at addressing these. Should I do that in a branch forked off this branch, so that we have CI on for python 3.7, or in branch forked off of master?

jamadden commented 6 years ago

The 3.6 builds raise a number of warnings (ala the pep) that can be tested for and silenced, so this could be checked against master with a PR that silences them all.

jamadden commented 6 years ago

This could get ugly. The code in question, SortingIndexMixin.sort, deliberately raises StopIteration without any context

jamadden commented 5 years ago

Replacing raise StopIteration with return doesn't break any tests on 2.7 or 3.6. On 3.5/3.6 we can use from __future__ import generator_stop to make it a hard error instead of a deprecation warning (but that breaks on Python 2.7 with a SyntaxError, so I don't think we can actually use it).

jamadden commented 5 years ago

I can push those things to this branch along with the other changes @mgedmin requested and hope the CI goes green.

jamadden commented 5 years ago

I'm waiting for Travis to turn green before hitting the merge button (appveyor is already green). There's a queue right now.

jamadden commented 5 years ago

Travis is green now, I'll merge and release.