search

zopefoundation / zope.publisher

Map requests from HTTP/WebDAV clients, web browsers, XML-RPC and FTP clients onto Python objects
Other
3 stars 13 forks source link

Fix file uploads on python 3.4 and up. #13

Closed jinty closed 8 years ago

jinty commented 8 years ago

cgi.FieldStorage explicitly closes files when it is garbage collected. For details, see:

We now keep a reference to the FieldStorage till we are finished processing the request.

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Travis is seriously unhappy on Python 3 for what look like unrelated reasons. Feel free to merge if the tests pass locally for you.

(In the past, instead of debugging the setup.py hacks that attempt to hook zope.testruner to setup.py test I'd change tox.ini to run zope-testrunner directly. E.g. zope.server's tox.ini is one example. Still, a matter for a separate pull request IMHO.)

mgedmin commented 8 years ago

Apologies for the comment flood.

I blame GitHub.

jinty commented 8 years ago

Wow, that's an impressive amount of comments. Here I thought you just wanted to make your point really clear;)

Thanks, I tried out your idea here: https://github.com/zopefoundation/zope.publisher/pull/14

It works pretty well and I managed to resist the temptation to type py.test rather than zope-testrunner...

I'll wait a bit for anyone who wants to approve then commit both PR's (as long as travis passes).

On Fri, Nov 04, 2016 at 03:37:44AM -0700, Marius Gedminas wrote:

Apologies for the comment flood.

I blame GitHub.

You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/zopefoundation/zope.publisher/pull/13#issuecomment-258396032

Brian Sutherland