Encode XMLRPC response bodies to bytes if needed.

zopefoundation / zope.publisher

Map requests from HTTP/WebDAV clients, web browsers, XML-RPC and FTP clients onto Python objects

Other

3 stars 13 forks source link

Encode XMLRPC response bodies to bytes if needed. #27

Closed jamadden closed 6 years ago

jamadden commented 6 years ago

Fixes #26.

Also use a modern tox coverage environment and remove outdated PyPy 2.5.0 workarounds in test_xmlrpc.py.

jamadden commented 6 years ago

Thanks!

How do we feel about releasing 5.0.0 at this point? There's one outstanding PR (#15) but it doesn't look like it has the impetus to move forward right now. (cc @icemac )

mgedmin commented 6 years ago

TBH knowing that file uploading is broken on Python 3 worries me somewhat, but, apparently, not enough to do something about it.

Let's do it. Releases are cheap, and this is not a regression.

jamadden commented 6 years ago

Then again, if fixing #15 might require some minor breaking changes, a 5.0 would be a good time to do it. I might have some time to look at it before the end of the year (but probably not in the next few days), so maybe we can hold off a bit longer to see if that happens.