search

zopefoundation / zope.publisher

Map requests from HTTP/WebDAV clients, web browsers, XML-RPC and FTP clients onto Python objects
Other
3 stars 12 forks source link

Support Python 3.9 #58

Closed icemac closed 3 years ago

icemac commented 3 years ago
icemac commented 3 years ago

CI seems to be broken because of https://github.com/actions/setup-python/issues/171.

cjwatson commented 3 years ago

You could temporarily pin uses: actions/setup-python@v2.1.4 as a workaround (or we could just wait for the fix).

icemac commented 3 years ago

I tried to use the new syntax suggested in https://github.com/actions/setup-python/issues/171#issuecomment-747917974 but check-python-versions does not like it. (maybe interesting for @mgedmin) I did not commit this, the output was:

check-python-versions
setup.py says:                    2.7, 3.5, 3.6, 3.7, 3.8, 3.9, PyPy
- python_requires says:           2.7, 3.5, 3.6, 3.7, 3.8, 3.9
tox.ini says:                     2.7, 3.5, 3.6, 3.7, 3.8, 3.9, PyPy, PyPy3
.github/workflows/tests.yml says: 2.7, 3.5, 3.6, 3.7, 3.8, 3.9, pypy-2.7, pypy-3.7

mismatch!
ERROR: InvocationError for command /.../zope.publisher/.tox/lint/bin/check-python-versions (exited with code 1)

So I am going with the suggestion of @cjwatson to downgrade to 2.1.4.

mgedmin commented 3 years ago

That is a bug in check-python-versions. I'd appreciate it if you could file it at https://github.com/mgedmin/check-python-versions/issues

mgedmin commented 3 years ago

https://github.com/actions/setup-python/issues/171#issuecomment-748114163 says the issue is fixed and we can use actions/setup-python@v2 again.

(Also, I pushed a new check-python-versions release that accepts the more detailed pypy-X.Y syntax.)

cjwatson commented 3 years ago

Hi @icemac - do you need any help getting this PR finished off?

icemac commented 3 years ago

@cjwatson I am planning to work on it today.

icemac commented 3 years ago

@mgedmin I think I implemented all your requested changes. Do you think this PR is now ready to be merged?