zopefoundation / zope.sqlalchemy

Integration of SQLAlchemy with transaction management
Other
32 stars 34 forks source link

Support sqlalchemy 1.4 #62

Closed tdamsma closed 3 years ago

tdamsma commented 3 years ago

Preliminary support for sqlalchemy 1.4, at least the tests are passing to solve #60

Incorporates #61 and #59

I think the changes made in this PR are enough to make zope.sqlalchemy src compatible with sqlalchemy 2.0 There are however still a lot of warnings raised in the test code. To be fully compatible with 2.0, at least this list of warnings will need to be addressed:

icemac commented 3 years ago

Let's defer this PR until #61 (and maybe #55) is/are merged.

jvanasco commented 3 years ago

FYI, @tdamsma

After doing some more tests regarding #57, I found a deficiency in the test suite. I added a comment to #57 describing the issue with the test case and offering an alternate test case that surfaces the regression.

sallner commented 3 years ago

@tdamsma Thank you for the contribution so far. We would like to proceed with the changes. I would prefer to move the list from the top to a separate issue. We can then merge this PR already, as it provides a valuable testing setup. This will allow us to cut release with SQLAlchemy 1.4 compatibility and go further with the drop of support for 0.9 and 1.0.

icemac commented 3 years ago

The coverage test fails because of current problems on the coveralls.io side.

icemac commented 3 years ago

See #64 as the followup for fixing the 2.0 deprecation warnings.