search

zopefoundation / zope.sqlalchemy

Integration of SQLAlchemy with transaction management
Other
32 stars 34 forks source link

this library is compatible with SQLAlchemy 1.4 branch on Python 2.7 #71

Closed jvanasco closed 3 years ago

jvanasco commented 3 years ago

We still keep an open-source project backwards compatible to Python2.7, and noticed this on a recent test failure:

https://github.com/zopefoundation/zope.sqlalchemy/blob/master/setup.py#L54

This library is still fully functional on Python2.7 with SQLAlchemy 1.4.7+

IMHO, it is worth supporting this combination, as a goal of the 1.4 branch of SQLAlchemy is to help legacy Python2 projects upgrade to Python3 and SQLAlchemy 2.0.

icemac commented 3 years ago

@jvanasco Dropping support for SQLAlchemy 1.4 at Python 2.7 does not seem to be necessary. This restriction was probably added because SQLAlchemy 1.4 does not support Python 3.5 any more.

I'll give it a try.

jvanasco commented 3 years ago

Thanks. The history suggested this was unintentionally dropped out when 3.5 was deprecated.

icemac commented 3 years ago

I just released https://pypi.org/project/zope.sqlalchemy/1.6/ including this fix.

jvanasco commented 3 years ago

Thank you kindly!