search

zopefoundation / zope.testbrowser

Programmable browser for functional black-box tests
Other
21 stars 16 forks source link

Flake8 #15

Closed florianpilz closed 8 years ago

florianpilz commented 8 years ago

Fixed more than 200 PEP8 errors and ignored folders for Virtualenv.

mgedmin commented 8 years ago

This is a bit too big to review comprehensibly. LGTM, mostly. Maybe let's merge the Py 2.6 support drop and rebase this so Travis is green?

Also, next time can you split the cleanups by type, e.g. blank line additions in one commit, long line wraps in another, noqa comments in a third etc. for ease of review? (I'm not asking to split this PR because that would be too much work for too little gain, but somethig to consider for the next time.)

florianpilz commented 8 years ago

I like the idea of committing each set of types separately. I agree that this is very hard to review. We will wait for green testbar.

mgedmin commented 8 years ago

I see six merge commits on top of this! Can you instead rebase on master? And then do the doctests = yes bit in setup.cfg like I asked? And then remove the now-unnecessary # noqa comments on imports that flake8 can see are used by doctests? Thanks!

florianpilz commented 8 years ago

I added the --doctests option that flake8 provides via CLI and removed the two # noqa comments for packages used in doctests. Instead of rebasing I will just squash the commit.