search

zopefoundation / zope.testbrowser

Programmable browser for functional black-box tests
Other
21 stars 16 forks source link

Be more defensive #3

Closed teixas closed 11 years ago

mgedmin commented 11 years ago

Sorry for losing track of this!

You asked to merge this change into the webtest branch. That branch has been superseded by the py3 branch (which added Python 3 support), which in turn has already been merged into master.

I'm getting merge conflicts when I try to merge your branch directly into master.

mgedmin commented 11 years ago

I've resolved the merge conflicts and am now seeing this test failure:

EDIT: never mind, I did something stupid with git stash.

mgedmin commented 11 years ago

Hm, I can't make the tests fail even if I revert your fix for Browser._findByLabel(). That either means your test isn't testing the fix, or I mungled something up while merging.

What is test_controls_without_value supposed to test? It seems to speak about controls without a value, but the included HTML sample has an control with a value. Is it the

mgedmin commented 11 years ago

Ok, I've reviewed all labels properties in zope.testbrowser, and it seems they've been changed so they never return blank or None entries. So the second fix is simply not necessary any more, and I'll drop it.

mgedmin commented 11 years ago

Now for the sad and boring due diligence part: the Zope Foundation Patch Policy requires me to ask you to sign the Zope Foundation Committer Agreement before I'm allowed to merge your patch. Unless it's considered to be too trivial to be copyrightable.

Actually, I think it is: there's just the one-liner patch remaining, plus the two unit tests.