Closed icemac closed 5 years ago
I've looked at it, and ugh. Dealing with long narrative doctests where the only test runner is tox -e docs
is like walking through mud.
Something changed in webob's cookie parser? Or we're not using it correctly? I noticed two problems:
The last successful build was https://travis-ci.org/zopefoundation/zope.testbrowser/builds/472125193. The first failed build was https://travis-ci.org/zopefoundation/zope.testbrowser/builds/474117777. The difference (looking at the Python 2.7 job):
Both builds had the same zope.testbrowser commit and had the same webob version.
cookie expiration date gets lost somewhere (on my machine)
This is because the tests are sensitive to the user's locale! :globe_with_meridians: :clown_face: :champagne:
If I set LC_TIME=C
, I can reproduce the KeyError problem I see on Travis.
(This might be an actual bug lurking somewhere!)
THE BLOODY NARRATIVE TEST SETS A COOKIE WITH AN EXPIRATION DATE OF JANUARY THE FIRST TWO THOUSAND AND NINETEEN ANNO DOMINI.
Nice :timer_clock: :bomb: !
See https://travis-ci.org/zopefoundation/zope.testbrowser/builds/485980587