search

zopencommunity / metaport

zopen package manager
Apache License 2.0
1 stars 2 forks source link

Update to readme for workflow #25

Closed netskink closed 11 months ago

netskink commented 1 year ago

@MikeFultonDev these are my notes regarding our work today. There are a few points of clarification in the notes, but perhaps this will be a good starting point for discussion.

Probably should add something along these lines for creating the pull request yadda yadda


After commit, fork the meta repo in github.  

After that do this

$ git add README.md $ git branch johndev $ git checkout johndev $ get remote add mine git@github.com:netskink/meta.git $ git push --set-upstream mine johndev



At this point, git will specify how to create a git pull request on meta via the push.
netskink commented 12 months ago

hmm. I just noticed this workflow has an error in this section:

Its a common practive to work in the ~/zopen/dev/ directory.

$ cd ~/zopen/dev
$ git clone git@github.com:ZOSOpenTools/meta.git
$ git clone git@github.com:ZOSOpenTools/metaport.git

I can't push to new branch for these repo's. I need to push to my forked version.

$ git push --set-upstream origin findutilsportE
Enter passphrase for key '/z/jd895801/.ssh/id_ed25519':
ERROR: Permission to ZOSOpenTools/meta.git denied to netskink.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
MikeFultonDev commented 12 months ago

Is the E on the end of the name ‘findutilsportE’ a typo?

netskink commented 12 months ago

Is the E on the end of the name ‘findutilsportE’ a typo?

It was intended. It’s E for error. I should have made e546, if 546 was the issue number.

MikeFultonDev commented 12 months ago

@IgorTodorovskiIBM i will leave this to you because a) you aren’t on vacation and b) you know for better than me

IgorTodorovskiIBM commented 12 months ago

Thanks @netskink , added a few more comments, but looking good overall. Thanks for the doing this.

IgorTodorovskiIBM commented 12 months ago

/run tests

netskink commented 12 months ago

/run tests

Is that something for me or some sort of trigger for github actions?

IgorTodorovskiIBM commented 12 months ago

/run tests

Is that something for me or some sort of trigger for github actions?

Yes, it triggers the github action.

I'm seeing this issue:

Installing package: zotsampleport
***ERROR: Could not get all releases for zotsampleport
Test of identifying port suffix failed.
/jenkins/PortBuild/meta/tests/zopen_check_install 43: FSUM7325 return: not executing function
FAIL: /jenkins/PortBuild/meta/tests/zopen_check_install

I see, so https://github.com/ZOSOpenTools/meta/pull/575 needs to be merged in first. We currently don't have a way to test anything other than the main brain via github actions.

IgorTodorovskiIBM commented 11 months ago

/run tests