search

zopieux / py-gfm

Github-Flavored Markdown for Python-Markdown.
https://pypi.org/project/py-gfm/
BSD 3-Clause "New" or "Revised" License
71 stars 14 forks source link

AttributeError: module 'markdown.inlinepatterns' has no attribute 'BRK' #13

Closed recrsn closed 6 years ago

recrsn commented 6 years ago 
Markdown==3.0
py-gfm==0.1.3

Python 3.6.6

Here is a sample code that causes the error

# imports ...
index_md = "# Hello World"
md = markdown.Markdown(extensions=[PartialGithubFlavoredMarkdownExtension()])
md.convert(index_md.read)
dvx76 commented 6 years ago

I just hit the same issue. FWIW it seems to be caused by the recent update of the markdown package to 3.0.0. As a workaround you can pin it to the previous version (markdown==2.6.11)

zopieux commented 6 years ago

Thanks for your report. Markdown 3.0.0 being a major release, most internal code have changed, making dependent code (including py-gfm) broken. I'll pin <3.0 in the dependencies before releasing a fix. Feel free to contribute a PR if you want a quicker release.

zopieux commented 6 years ago

py-gfm 0.1.4 was pushed and released to PyPi.

brunobord commented 5 years ago

Hello @Zopieux: did you find some time to work on unpin the Markdown requirement? Do you know what precisely introduced this incompatibility?

ignatenkobrain commented 4 years ago

@Zopieux ping

lsuttle commented 4 years ago

Looks like there's a couple months old PR that resolves this issue, any chance that can be reviewed?

shua commented 4 years ago

Can we reopen this? I am seeing this issue with mkdocs (markdown >3.0) and latest py-gfm