gym/wrappers has removed "Monitors" and are using "RecordEpisodicStatistics"

dnabanita7 commented 2 years ago

I got this error while running README.md. Stack Trace:

iex(1)> 
13:34:16.528 [error] GenServer #PID<0.199.0> terminating
** (stop) {:python, :"builtins.ImportError", 'cannot import name \'Monitor\' from \'gym.wrappers\' (/home/naba/anaconda3/lib/python3.9/site-packages/gym/wrappers/__init__.py)', {:"$erlport.opaque", :python, <<128, 2, 99, 116, 114, 97, 99, 101, 98, 97, 99, 107, 10, 83, 116, 97, 99, 107, 83, 117, 109, 109, 97, 114, 121, 10, 113, 0, 41, 129, 113, 1, 40, 99, 116, 114, 97, 99, 101, 98, 97, 99, 107, ...>>}}
    /home/naba/dev/gym_tcp_api/deps/erlport/src/erlport.erl:234: :[erlport.call/3](http://erlport.call/3)
    (gym_tcp_api 0.1.0) lib/worker.ex:25: GymTcpApi.Worker.handle_call/3
    (stdlib 3.14) gen_server.erl:715: :gen_server.try_handle_call/4
    (stdlib 3.14) gen_server.erl:744: :gen_server.handle_msg/6
    (stdlib 3.14) proc_lib.erl:226: :proc_lib.init_p_do_apply/3
Last message (from #PID<0.208.0>): {"{\"env\":{\"name\": \"CartPole-v0\"}}\r\n", #PID<0.207.0>}
State: #PID<0.200.0>
Client #PID<0.208.0> is alive

This states that we can no longer use monitor.hpp. We need to have something similar to RecordEpisodeStatistics. This issue is helpful.

zoq commented 2 years ago

Thanks for the detailed issue report, is that something you like to look into further, or should I create a patch for it?

dnabanita7 commented 2 years ago

I have already started some work on it, if that okay with you?

On Tue, 5 Apr, 2022, 8:00 am Marcus Edel, @.***> wrote:

Thanks for the detailed issue report, is that something you like to look into further, or should I create a patch for it?

— Reply to this email directly, view it on GitHub https://github.com/zoq/gym_tcp_api/issues/16#issuecomment-1088206019, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHQZX557YTRVE726HZW6AJ3VDOQVDANCNFSM5SP24SWQ . You are receiving this because you authored the thread.Message ID: @.***>

zoq / gym_tcp_api

gym/wrappers has removed "Monitors" and are using "RecordEpisodicStatistics" #16