Only display expand/collapse class and disclose span when tree node has children

zorab47 / active_admin-sortable_tree

Show ActiveAdmin index as a nested tree with drag'n'drop

MIT License

162 stars 127 forks source link

Only display expand/collapse class and disclose span when tree node has children #25

Closed zarazan closed 10 years ago

zarazan commented 10 years ago

When a tree node is empty the plus/minus sign is still displayed and so is the mouse hover. This commit removes these items for empty tree nodes.

zarazan commented 10 years ago

@nebirhos What is that status of this project? Have you reviewed this pull request? I would also like to update this project to Rails 4 to match the master active_admin branch. Let me know if this work has already been started.

nebirhos commented 10 years ago

Hi @zarazan! Thanks for your fixes, I merged into master with some slight changes:

reverted the vendored nestedSortable.js, since we should not rely on patches that could be deleted on an upgrade. You should provide a pull request to https://github.com/mjsarfatti/nestedSortable
shortened if syntax

About Rails 4 and AA compatability, we're working on a base suite of tests before, so we can check on every version safely.

zarazan commented 10 years ago

Thanks @nebirhos! Let me know if there is anything I can help with. I made a pull request on the nestedSortable project.