search

zorab47 / active_admin-sortable_tree

Show ActiveAdmin index as a nested tree with drag'n'drop
MIT License
163 stars 127 forks source link

Update README.md #59

Closed supremebeing7 closed 7 years ago

supremebeing7 commented 7 years ago

Reference: https://github.com/activeadmin/activeadmin/issues/3803

zorab47 commented 7 years ago

I've been using it with older versions of ActiveAdmin (0.6.x and some along the master branch). What was the bug and when might it have been introduced? I don't want to mislead new users of the gem on which version is required.

supremebeing7 commented 7 years ago

Hm, I'm not sure when it was introduced. I've been on 1.0.0.pre since coming to this project. I understand your concern. I can try to research a bit and try to nail down when the bug was introduced. If we can't figure that out, would it be worthwhile to change the wording in this PR? Something like "If you experience issues with drag and drop, you may need to specify the version..."

supremebeing7 commented 7 years ago

I found this: https://github.com/activeadmin/activeadmin/pull/3776#issue-55983781 Which makes it sound like this error is sporadic (which is the best kind of error 🎉 ).

I also found this: https://github.com/activeadmin/activeadmin/issues/4198 At the end, one of AA's maintainers says that the fix was backported to v0.6.6.

Either of those could be why you haven't experienced this error. Either way, I think just changing the language in my edits like I suggested above might make the most sense. Let me know what you think, or if you don't think README edits are necessary.

zorab47 commented 7 years ago

Agreed, I think a wording update would be wise. Providing this warning could help others avoid similar issues.

supremebeing7 commented 7 years ago

Updated wording. Let me know if anything else is needed.

Thanks for the great gem, hopefully this saves someone else some head-scratching.

zorab47 commented 7 years ago

Thanks!