search

zorab47 / active_admin-sortable_tree

Show ActiveAdmin index as a nested tree with drag'n'drop
MIT License
163 stars 127 forks source link

Compatibility with Rails >= 5.1.0 #64

Closed schovi closed 7 years ago

zorab47 commented 7 years ago

Thanks for the PR. Do you know if the separator: keyword is valid for older versions of Rails?

zorab47 commented 7 years ago

My initial search shows that it is a keyword in Rails 5.0+. Perhaps it was introduced in 4.2?

schovi commented 7 years ago

@zorab47 I think it is not valid. Is it time to begin 1.x version for rails 5 and more? :)

zorab47 commented 7 years ago

Yes, I think it is time for a 1.0. On Mon, May 22, 2017 at 4:34 PM David Schovanec notifications@github.com wrote:

@zorab47 https://github.com/zorab47 I think it is not valid. Is it time to begin 1.x version for rails 5 and more? :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zorab47/active_admin-sortable_tree/pull/64#issuecomment-303226219, or mute the thread https://github.com/notifications/unsubscribe-auth/AABiBnpMiTpPDbOJMk9AoJBqXxH3_rIXks5r8f9NgaJpZM4NfPui .

zorab47 commented 7 years ago

Released a v1.0.0 with support for both Rails 4.2, 5.0, and 5.1. Thanks for your PR!