zorab47 / active_admin-sortable_tree

Show ActiveAdmin index as a nested tree with drag'n'drop
MIT License
163 stars 127 forks source link

Move assets register to the user files. #67

Closed merqlove closed 6 years ago

merqlove commented 7 years ago

New AA (1.1+) will deprecate assets registering.

merqlove commented 7 years ago

Also i think we can drop :sortable :sortable_ui5 js. Because ppl can manually require dependencies.

zorab47 commented 6 years ago

I'd like to continue supporting older versions of ActiveAdmin. I see the change mentioning the deprecation of the registration methods. Conditionally supporting both AA 1.0 and AA 2.0 (I assume) will be necessary.

merqlove commented 6 years ago

Maybe better is to make some major release?

merqlove commented 6 years ago

We can also check, if AA >= 1.1.0 then register helpers will be disabled.

zorab47 commented 6 years ago

Released v2.0.0 suggesting to use the manual inclusion methods (in preparation for ActiveAdmin 2.0)