search

zorab47 / active_admin-sortable_tree

Show ActiveAdmin index as a nested tree with drag'n'drop
MIT License
163 stars 127 forks source link

remove register_assets as it is deprecated #76

Closed anup1710 closed 4 years ago

zorab47 commented 6 years ago

Thanks for PR. However, I'll probably make this a configuration option to conditionally avoid the deprecation warnings.

entity1991 commented 6 years ago

@zorab47 , so it is already implemented? I have next deprecation messages:

DEPRECATION WARNING: Active Admin: The `register_stylesheet` config is deprecated and will be removed
in v2. Import your "active_admin/sortable.css" stylesheet in the active_admin.scss.
 (called from <top (required)> at /home/entity/work/own/MoneyMotion/config/environment.rb:7)
DEPRECATION WARNING: Active Admin: The `register_javascript` config is deprecated and will be removed
in v2. Import your "active_admin/sortable.js" javascript in the active_admin.js.
 (called from <top (required)> at /home/entity/work/own/MoneyMotion/config/environment.rb:7)

How to ger rid of them? Is there already some configuration?

zorab47 commented 6 years ago

@entity1991 currently there isn't a configuration option. Help would be appreciated.

matthewopk commented 5 years ago

The readme already instructs to add manually the css and js into your project. I think it's safe to remove register_stylesheet and register_javascript now.