Open Fivell opened 7 years ago
I'm happy to help get this integrated into ActiveAdmin. Answers are below:
#parent
in Arbre context)helpers.parent
, but it seems strange when the docs for inherited_resources's belongs_to suggest using the controller#parent
method directly.helpers
method for this purpose until you mentioned it.Have you experienced the issue related to calling #parent
in an Arbre context? Perhaps my resources are configured in a strange way??
@zorab47 , yes I had, but after I figured out that parent can be called on helpers.
So helpers.parent
works instead of parent
@zorab47 , I will setup your gem when I have free time and check if something can be improved.
FYI, I've released a new version with compatibility with ActiveAdmin 1.0.0.
Hello @zorab47 , hope you're doing well and someday this gem will be merged to activeadmin. I just wanted to notify you about next changes that can reflect to this gem.
1) about pages pages are supports belongs_to, so there is no reason to skip pages from
active_admin-subnav
take a look https://github.com/activeadmin/activeadmin/pull/47592) about extra setup
can you explain why this needed ? and why it is not possible to use
helpers.parent
inarbre
https://github.com/Fivell/activeadmin/blob/05877d45d464d1911ca7d53072c81516c7614281/features/registering_pages.feature#L1813) about controller hack
https://github.com/zorab47/active_admin-subnav/blob/master/lib/active_admin/subnav/extensions/base_controller.rb#L11
Can you please explain why this needed, maybe we'll find more clean workaround for this
Thanks