Minor error in `Shadow Depth`

zoran-cuckovic / QGIS-terrain-shading

Modelling natural shading for elevation models in QGIS

GNU General Public License v3.0

72 stars 11 forks source link

Minor error in `Shadow Depth` #10

Closed JanCaha closed 3 years ago

JanCaha commented 3 years ago

If I run Shadow Depth algorithm I see an error:

TerrainShading\shading_algorithm.py", line 288, in postProcessAlgorithm path = path.dirname(__file__) + path AttributeError: 'str' object has no attribute 'dirname'

Looking at the code at that line, there seems to be type a typo.

path = path.dirname(__file__) + path should probably be path = os.dirname(__file__) + path.

It does not crash the algorithm and even the result is obtained fine, just the style is not applied.

zoran-cuckovic commented 3 years ago

Ah, what a basic error ! I'll wait for one more week, and publish a fixed version. Thank you for reporting !

JanCaha commented 3 years ago

Just a minor problem. It happens to everyone. Otherwise the plugin is great ;-)