zoran-cuckovic / QGIS-visibility-analysis

Quantum GIS plugin for visibility analysis
GNU General Public License v3.0
72 stars 18 forks source link

Intervisibility target height #19

Closed zoran-cuckovic closed 6 years ago

zoran-cuckovic commented 6 years ago

Version 0.6.1 (experimental) is producing unrealistic output from the Intervisibilty algo. Target height is sometimes much greater than the one specified in parameters. The routine is, in fact, adding the height of target's pixel to the outcome. The analysis is not incorrect (there should be no false positives).

The line :

    tgs[id2]["depth"]= depth + z_targ #z_targ if depth >= 0 else depth + z_targ

should be tgs[id2]["depth"]= z_targ if depth >= 0 else depth + z_targ

zoran-cuckovic commented 6 years ago

Fixed in 0.6.2 version