search

zorbash / opus

A framework for pluggable business logic components
MIT License
354 stars 21 forks source link

Decouple Graphvix #10

Closed hl closed 5 years ago

hl commented 5 years ago

Environment

Current behavior

This is both a bug report and feature request. I think it's better to decouple Graphvix from Opus because it doesn't add anything for production. I'm also getting the below error on version 0.5 (version 1.0 is released)

[error] Graphvix.Graph Graphvix.Graph received unexpected message in handle_info/2: :save_state

Expected behavior

No error and decoupling

zorbash commented 5 years ago

I'm extracting this to a separate optional package on which you can depend on the environments you intend to run Opus.Graph using:

# in mix.exs
def deps
  {:opus, "> 0.5"},
  {:opus_graph, "~> 0.1", only: [:dev]}
end
zorbash commented 5 years ago

opus_graph has been published, so you if you depend on the edge version of opus you won't have that issue. Let me know if that works for you.

hl commented 5 years ago

Works great, thanks!

zorbash commented 5 years ago

@hl btw if you're using the library and you find it useful, consider suggesting it to be included in https://github.com/h4cc/awesome-elixir 🙏

hl commented 5 years ago

Done https://github.com/h4cc/awesome-elixir/issues/4519

Can you cut me a release?

churcho commented 5 years ago

I am getting the following error when I run my tests : Graphvix.Graph Graphvix.Graph received unexpected message in handle_info/2: :save_state I can see it's referenced in this issue.

What could I be missing? I am using the latest branch.

zorbash commented 5 years ago

@churcho Do you depend on the master branch of this library 08ed635a9936e83ef779524ace9fc63122e14ff8 ?

churcho commented 5 years ago

@zorbash not getting this anymore with the new update. It's resolved for me.