Fixes ex_doc dep to be within 0.18.x version

zorbash / opus

A framework for pluggable business logic components

MIT License

354 stars 21 forks source link

Fixes ex_doc dep to be within 0.18.x version #14

Closed rafaels88 closed 5 years ago

rafaels88 commented 5 years ago

Since Opus is using Elixir ~>1.4, it should keep the ex_doc version at 0.18.0 as mentioned in the documentation (ref: https://github.com/elixir-lang/ex_doc#using-exdoc-with-mix)

When trying to compile Opus using Elixir 1.4, then we get:

could not compile dependency :ex_doc, "mix compile" failed.
You can recompile this dependency with "mix deps.compile ex_doc",
update it with "mix deps.update ex_doc" or clean it with "mix deps.clean ex_doc"

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 83

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 82:	0.0%
Covered Lines:	99
Relevant Lines:	99

💛 - Coveralls

zorbash commented 5 years ago

👍 This will allow building and publishing Opus on Elixir <= v1.6 while not affecting dependant apps. A downstream v1.7 app may add:

{:ex_doc, "~> 0.19.0", runtime: false}

in mix.exs

Thanks for this PR.