Add :unless as option for stages

zorbash / opus

A framework for pluggable business logic components

MIT License

354 stars 21 forks source link

Add :unless as option for stages #15

Closed rafaels88 closed 5 years ago

rafaels88 commented 5 years ago

This PR introduces the :unless option as suggested in https://github.com/zorbash/opus/issues/13

If approved, this PR is still pending:

[ ] - Discuss (and apply, if necessary) the version number of which this PR will be related to

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 84

6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 82:	0.0%
Covered Lines:	105
Relevant Lines:	105

@rafaels88 Concerning the version, this is backwards compatible and in theory belongs to ~0.6. Despite it not being a hotfix, I'm not against including it in a patch release like 0.5.3 for people to be able to use it from hex. Releasing it in a patch version doesn't follow semantic versioning, on the other hand it doesn't jeopardise any dependant apps. sanity > purity.

zorbash / opus

Add :unless as option for stages #15

Pull Request Test Coverage Report for Build 84

💛 - Coveralls