Move code in ./common into the main directory?

zorchenhimer / MovieNight

Single instance video streaming server with integrated chat.

https://discord.gg/F2VSgjJ

MIT License

683 stars 87 forks source link

Move code in ./common into the main directory? #177

Closed joeyak closed 1 year ago

joeyak commented 2 years ago

Now that wasm is being removed in https://github.com/zorchenhimer/MovieNight/issues/168 we can move the code in common out because it's not longer being used. Now an alternative to that is leave it in common because it does break up the code somewhat into smaller sections.

CptPie commented 2 years ago

Speaking from my own (biased) opinion/experience with moviepolls, i would try to keep your main directory as "clean" as possible, basically only having the main.go, buildfiles and other stuff (linter config) in the main dir.

joeyak commented 2 years ago

hmm good point. Maybe we need to restructure the root directory a bit more? One thing I definitely want to do is combine emotes.go and common/emotes.go

zorglube commented 2 years ago

Il vote for @CptPie point of view ! (Whatever worth my vote 🤣).

joeyak commented 1 year ago

common/emotes was combined into emotes.go with the embed branch