search

zorchenhimer / MoviePolls

Voting to decide on a movie to watch with MovieNight
https://discord.gg/F2VSgjJ
16 stars 6 forks source link

Partial CSS-Rework code #98

Closed Flyken271 closed 2 years ago

Flyken271 commented 3 years ago

This is the partial code for 'Project-Css-Rework', this PR is intended for preliminary review by repomaster.

CptPie commented 3 years ago

So whats going on with this PR - are you waiting on input or smth?

Flyken271 commented 3 years ago

So whats going on with this PR - are you waiting on input or smth?

i honestly think we should push it for now, all of the front-facing CSS is done and only the admin panels and such are still the same, ive been having some life stuff popping up and might not be able to get to the other things right now.

if its cool with both you and zorch it'd be safe to push

CptPie commented 3 years ago

So whats going on with this PR - are you waiting on input or smth?

i honestly think we should push it for now, all of the front-facing CSS is done and only the admin panels and such are still the same, ive been having some life stuff popping up and might not be able to get to the other things right now.

if its cool with both you and zorch it'd be safe to push

If thats the case convert the Draft back to a PR and i'll review it later/tomorrow

Flyken271 commented 2 years ago

its been over a year, can we freaking merge this now?

zorchenhimer commented 2 years ago

I was waiting until the other PR was merged because I knew changes would need to be made afterwards.

zorchenhimer commented 2 years ago

Looks pretty good, but there's some minor things I noticed.

The search box collides with the message for the last movies watched (this is hard to capture when the box is expanded): image

The tags can overlap the movie description: image

When adding a movie, the remarks textarea has a different style: image

Flyken271 commented 2 years ago

Looks pretty good, but there's some minor things I noticed.

The search box collides with the message for the last movies watched (this is hard to capture when the box is expanded): image

The tags can overlap the movie description: image

When adding a movie, the remarks textarea has a different style: image

the title bar was discussed with pie to put it there and like that, the different style on that text area can be fixed with an extra PR as well with the tags position, could we just merge this as is and i'll get to work on those issues in a new PR right away? (just to get this dang thing out of here and merged? :P )

zorchenhimer commented 2 years ago

This was accidentally merged with 3c0c72671f2fddd11e24c131ef490a94eeea45c3. Whoops. I then proceeded to break it further.

Everything's back on track now though (a force push happened).