zordius / lightncandy

An extremely fast PHP implementation of handlebars ( http://handlebarsjs.com/ ) and mustache ( http://mustache.github.io/ ),
https://zordius.github.io/HandlebarsCookbook/
MIT License
608 stars 76 forks source link

Start testing on PHP 7.4 #326

Closed reedy closed 4 years ago

reedy commented 4 years ago

Added the fix for #329 ontop of this patch, as it's difficult otherwise to show the failure as seen in https://travis-ci.org/zordius/lightncandy/builds/638822629 caused by adding testing on PHP 7.4 - the first commit passes fine, it only fails when error handling is added to the bash script_

Other supporting patches (#336 and #328) probably want merging first, then this should pass ontop of these

zordius commented 4 years ago

Thank you for your contribution!