Closed mitsh closed 3 years ago
This is also helping for me. I'm also on php 8. Not sure if it is the right way to go, I hope we get some feedback on that. I had a similar error, mine was
CRITICAL: Uncaught Exception ParseError: "syntax error, unexpected token ","" at /tmp/lci_Z3NgN8 line 14 {"exception":"[object] (ParseError(code: 0): syntax error, unexpected token \",\" at /tmp/lci_Z3NgN8:14)"}
My fix. Not tested enough yet: https://github.com/yurikuzn/lightncandy/commit/207d424c4ced34644663fdc0758c19d5b6974adc
I actually came across this and ended up doing the same thing you did. The problem is the change isn't backwards compatible.
Just tried out the above fix yurikuzn@207d424 and it works nicely! Thanks
My fix. Not tested enough yet: yurikuzn@207d424
Works for me, too. Can you make a PR from this @yurikuzn ?
@yurikuzn's approach is more compatible than mine. so, we can close this issue.
This issue has appeared after upgrading to PHP8.
I did a search and found the problem and I made a change in this file; ./src/vendor/lightncandy/Exporter.php
Is this a correct way to fix it?