search

zordius / lightncandy

An extremely fast PHP implementation of handlebars ( http://handlebarsjs.com/ ) and mustache ( http://mustache.github.io/ ),
https://zordius.github.io/HandlebarsCookbook/
MIT License
610 stars 76 forks source link

.git included in vendor distribution causes errors in grunt and other tools #368

Closed bandtank closed 8 months ago

bandtank commented 8 months ago

When I include this repo in projects, there is an issue that I never see with other vendor distributions, which results in needing to use --force with grunt:

Warning: Unable to write "build/tmp/vendor/zordius/lightncandy/.git/objects/pack/pack-c9c2cbbccf4beb1572bd717e9ffabd682a09a30f.idx" file (Error code: EACCES). Use --force to continue.

The inclusion of the .git folder causes a lot of issues due to the inherent lack of write permissions:

$ ll build/tmp/vendor/zordius/lightncandy/.git/objects/pack/pack-c9c2cbbccf4beb1572bd717e9ffabd682a09a30f.idx
-r--r--r--  1 user  staff  281408 Sep 27 10:31 build/tmp/vendor/zordius/lightncandy/.git/objects/pack/pack-c9c2cbbccf4beb1572bd717e9ffabd682a09a30f.idx

When I look for .git folders in other vendor distributions (100+), this is what I find:

$ find vendor -name ".git"                                                                                 
vendor/zordius/lightncandy/.git

Please remove .git from the distribution.

bandtank commented 8 months ago

Nevermind. The issue was introduced by someone else. Nothing to see here.