Closed lilmike closed 2 years ago
zorggn
commented
2 years ago Hi!
I have ran into this bug on my end previously, but i haven't gotten around to pushing my local changes for fixing this.
I did so now however, so please test out the updated library, and if it fixes the issue, then i'll close it as solved. :3
lilmike
commented
2 years ago Hiya,
Unfortunately, still no dice. Just pulled, copied asl.lua and asl-threat.lua to my project but still no sound. :/. I'm at quite a loss as to what could possibly be causing this heh.
-Michael.
zorggn
commented
2 years ago In this case, i'd like to ask for a minimal example that reproduces the issue; without anything audio related or otherwise that might not be relevant to the issue.
lilmike
commented
2 years ago Here is a .love file with a very basic setup of ripple (patched to use ResamplingRatio instead of Pitch). Basic usage is to run love on the .love file, and then press space. You are supposed to hear a sound looping, and pressing space more times will overlay them. This does not work with asl though.
-Michael.
Arg, I zipped it because github doesn't support .love :/
zorggn
commented
2 years ago Thanks for the test case! I managed to find the issue; for some reason, cloning a queueable source does not give back a functioning one, so two things will happen:
Please do test it out, if it works (and it should now), then i'll close the issue as solved. :3
zorggn
commented
2 years ago Edit: It might not be a löve issue after all, since i couldn't reproduce it outside of this library; i'll rewrite the codebase soon once more anyway, hopefully that'll get rid of it; for now, the fix i committed does work.
lilmike
commented
2 years ago Hiya,
Confirmed working. Thank you!
-Michael.
On Fri, Sep 23, 2022 at 02:49:14AM -0700, zorg wrote:
Edit: It might not be a löve issue after all, since i couldn't reproduce it outside of this library; i'll rewrite the codebase soon once more anyway, hopefully that'll get rid of it; for now, the fix i committed does work.
-- Reply to this email directly or view it on GitHub: https://github.com/zorggn/love-asl/issues/1#issuecomment-1256006893 You are receiving this because you authored the thread.
Message ID: @.***>
-- Sorry about the test, it's just a me thing. Michael Taboada, Creator of Games. Does that make me a god, well, sorta. My pgp key: 79BC390E8864CD71305D4DD606CD2197A6EE5ED7 My website: https://michaels.world 2MB website: https://2mb.games Don't believe everything you read on the internet. I might not be real, you might not be real, and this email certainly isn't real. Sent from my kitchen... mattress
Hiya,
I'm trying to convert my audiogame project to asl plus ripple, and am having an issue. The changes are all in the sound-rework branch. If I play a sound by making a new advanced source object then playing it, the sound plays fine. However, with all the ripple sounds, nothing plays. I've tried doing every step that ripple does on creating a new instance manually to the single advanced source in love.load, and it still works great, so I'm really stumped. You can find my issue on ripple's github here: https://github.com/tesselode/ripple/issues/9
Btw, in ripple.lua, you need to change getPitch and setPitch appropriately, which i have done, so asl isn't exactly a dropin right now :-).
Any help is appreciated! :-)
-Michael.