Missing dollarsign on script - Githubissues

zorglube / freenas-iocage-movienight

FreeNAS MovieNight Plugin

GNU General Public License v3.0

1 stars 0 forks source link

Missing dollarsign on script #1

Closed boyobejamin closed 3 years ago

boyobejamin commented 3 years ago

Hey there, in the movienight-jail.sh script, should the following line have $ added?

if ! iocage exec ${JAIL_NAME} chown {UID}:{GID} ${MN_LOG_FILE}
if ! iocage exec ${JAIL_NAME} chown ${UID}:${GID} ${MN_LOG_FILE}

zorglube commented 3 years ago

Seems you're right. Did you made some test ?

boyobejamin commented 3 years ago

Yeah, the installation failed without it because it wasn't able to resolve to a good GID/UID.

I'm going to look at the start script too today. There are some similar small things to be fixed to get that rocking.

I'm super excited to have this easily working on my FreeNAS box!

zorglube commented 3 years ago

Thank you !

Do not hesitate to ask questions and make some feedback, I need some to improve.

See ya, Zorglube

zorglube commented 3 years ago

Hey @boyobejamin , did you made some tests ?

boyobejamin commented 3 years ago

Yeah, here's a PR where I've made other changes to get it working. Everything currently deploys successfully with the following modifications.

https://github.com/zorglube/freenas-iocage-movienight/pull/3

I was going to turn this into a FreeNAS plugin but time got away from me. Hopefully this helps others!

zorglube commented 3 years ago

I was going to turn this into a FreeNAS plugin but time got away from me. Hopefully this helps others!

I also want to do this, maybe we should work together ?

boyobejamin commented 3 years ago

Totally! I'd be down for that. I'm busy this weekend but will make time this week to research the effort. A cursory glance shows it's not a huge lift to make it a plugin.

zorglube commented 3 years ago

Their at least two way to make an FreeNAS/TrueNAS plugin.

We can make an TrueNAS plugin with a lot of script into the post_install.sh. Like: Create Jail, and post install contain install GoLang, Clone repo, Compile and run and so on.
We can create an BSD Port of MovieNight then an TrueNAS plugin. This solution seems to be better.

Do you have some idea ? Point of view ?