search

zorigitano / multipage-webpack-plugin

A plugin that makes handling templates and asset distribution for multi-page applications using webpack trivial
Apache License 2.0
170 stars 15 forks source link

feat(options): support htmlWebpackPlugin options & replace [name] in … #34

Closed xiaoiver closed 7 years ago

xiaoiver commented 7 years ago
  1. support other htmlWebpackPlugin options, like inject, favicon
  2. also replace [name] in htmlTemplatePath
coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling bc93feb7b0f65943731ab175576033bb84a86152 on lavas-project:master into 08eeb6c2270deb6cf6553f935e9cccb5c1829bcc on mutualofomaha:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling bc93feb7b0f65943731ab175576033bb84a86152 on lavas-project:master into 08eeb6c2270deb6cf6553f935e9cccb5c1829bcc on mutualofomaha:master.

TheLarkInn commented 7 years ago

@xiaoiver This is a really great idea to have an escape hatch for the rest of the options.

Could you please add a few test cases for the specific features you are leveraging from htmlWebpackPluginOptions?

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 93d5ee3642046064f788e4269abb2f4f8de8d1dd on lavas-project:master into 08eeb6c2270deb6cf6553f935e9cccb5c1829bcc on mutualofomaha:master.

xiaoiver commented 7 years ago

I added a simple test case for minify and favicon options in html-webpack-plugin. Is there anything I should complement？

TheLarkInn commented 7 years ago

Thank you @xiaoiver for the contribution. We use semantic release to automatically publish so please keep an eye on master branch Travis build to see when update is published