search

zoriya / Kyoo

A portable and vast media library solution.
https://kyoo.zoriya.dev
GNU General Public License v3.0
1.64k stars 38 forks source link

Add media type filter #528

Closed scme0 closed 3 months ago

scme0 commented 3 months ago

Background

The first step to adding a series of filters on the browse page.

Discord discussion: https://discord.com/channels/1216460898139635753/1241683417180143646/1241683417180143646

Results

I've been working on a searchable multi-select drop down component but it's taking a bit longer than I had hoped as I haven't had a lot of time in the last few weeks. I feel like this would be the ideal way to filter things to genres where there are a lot of options and you might want to select multiple.

While working on that, and to get things started in this area, I thought we could add this basic Media Type filter which will allow users to select the media type they wish to browse. I thought the Menu component was suitable as there are only 3 options.

Demo

Screen Recording 2024-06-08 at 18 26 43

zoriya commented 3 months ago

Really good PR, with a nice usage of components and existing libraries!

I added some nitpicks here and there but it looks really good!

I'll test this tonight or tomorrow!

scme0 commented 3 months ago

I've just realised that the search query doesn't support filters yet. I guess we'll need to implement that before we can bring this in otherwise the UX is confusing, unless we hide the filters on the browse page when someone does a manual search.

scme0 commented 3 months ago

I've created another PR to add filtering to the search endpoint in the backend: https://github.com/zoriya/Kyoo/pull/530.

Still a WIP as I haven't tested it yet.

zoriya commented 3 months ago

Thanks for your hard work on this! Really happy to have this now!