zoriya / Kyoo

A portable and vast media library solution.
https://kyoo.zoriya.dev
GNU General Public License v3.0
1.32k stars 29 forks source link

Switch to fmp4 intead of mgepg #542

Open zoriya opened 2 weeks ago

zoriya commented 2 weeks ago

Closes #534

Refs:

Currently, this PR is not working, I guess timestamps or mp4 headers are invalid /shrug

zoriya commented 2 weeks ago

Maybe it would be wisest to switch to -f hls instead of -f segment to use their built-in fmp4 handling. Would need to check if it's possible to use segments from multiples transcode process this way tho.

zoriya commented 3 days ago

I'm realising supporting this would allow av1 streaming.

This would be huge to reduce bandwidth usage.

Definitely want to work on this on the following days

zoriya commented 12 hours ago

Idea seem to work, need to:

zoriya commented 12 hours ago

We would need to fix the assumption that keyframes are a file level things. This should move to a stream level thing.

It's legal to have audio/video with different segments. It's also legal to have two videos w/ different segments. The only constraint is that variant should have the same segments (aka video1/720p & video2/1080p needs same segments while video1/729p & video2/1080p can have different segments).

Doing this would also unlock video selection when the file contains multiple video streams.

zoriya commented 12 hours ago

I'm thinking of first fixing this & data store in another PR before continuing this.