zoriya / Kyoo

A portable and vast media library solution.
https://kyoo.zoriya.dev
GNU General Public License v3.0
1.32k stars 29 forks source link

Transcoder: Handle Base64 path with slash #551

Closed Arthi-chaud closed 3 days ago

Arthi-chaud commented 1 week ago

Kyoo's version

v4.6.0

What happened?

Some path converted to base64 contains slashes. Unfortunately, the router in the transcoder interprets what's after the slash as the quality to convert to.

One possible solution would be for the transcoder to accept url-encoded base64 strings (and update the front app to properly encode that value)

zoriya commented 1 week ago

I don't really like the idea of using non-standard systems like that. We could try to switch to another encoding standard instead. Or maybe there is a standard way of handling base64 in url/paths.

zoriya commented 3 days ago

Turns out the base64 spec took that into account and created a url form for base64