search

zoriya / Opus

Android app for playing music from local file or from youtube.
https://www.raccoon-sdg.fr/en
GNU General Public License v3.0
9 stars 2 forks source link

[Opus][v3.4.1]App failed to play music. #26

Closed masudr4n4 closed 5 years ago

masudr4n4 commented 5 years ago

Actual behavior

App crashes if i try to play music.when reproducing the bug sometime it plays first song succesfully but then if try to play another music it crashes again.

Expected behavior

Expected that can play music.Permission allowed successfully but still unable playmusic.

How to reproduce

  1. Install the apps and open the app
  2. Click Brows
  3. Allow storage permission
  4. Click any song to play
  5. See the error

Information

Recording Of The Bug

https://youtu.be/E1nsFE-9H04

Logcat


06-25 11:15:46.011 20850 20850 E AndroidRuntime: FATAL EXCEPTION: main
06-25 11:15:46.011 20850 20850 E AndroidRuntime: Process: com.sdg.opus, PID: 20850
06-25 11:15:46.011 20850 20850 E AndroidRuntime: java.lang.IllegalArgumentException: x must be >= 0
06-25 11:15:46.011 20850 20850 E AndroidRuntime:    at android.graphics.Bitmap.checkXYSign(Bitmap.java:429)
06-25 11:15:46.011 20850 20850 E AndroidRuntime:    at android.graphics.Bitmap.createBitmap(Bitmap.java:842)
06-25 11:15:46.011 20850 20850 E AndroidRuntime:    at android.graphics.Bitmap.createBitmap(Bitmap.java:811)
06-25 11:15:46.011 20850 20850 E AndroidRuntime:    at mono.java.lang.RunnableImplementor.n_run(Native Method)
06-25 11:15:46.011 20850 20850 E AndroidRuntime:    at mono.java.lang.RunnableImplementor.run(RunnableImplementor.java:30)
06-25 11:15:46.011 20850 20850 E AndroidRuntime:    at android.os.Handler.handleCallback(Handler.java:873)
06-25 11:15:46.011 20850 20850 E AndroidRuntime:    at android.os.Handler.dispatchMessage(Handler.java:99)
06-25 11:15:46.011 20850 20850 E AndroidRuntime:    at android.os.Looper.loop(Looper.java:214)
06-25 11:15:46.011 20850 20850 E AndroidRuntime:    at android.app.ActivityThread.main(ActivityThread.java:7073)
06-25 11:15:46.011 20850 20850 E AndroidRuntime:    at java.lang.reflect.Method.invoke(Native Method)
06-25 11:15:46.011 20850 20850 E AndroidRuntime:    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
06-25 11:15:46.011 20850 20850 E AndroidRuntime:    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:964)
zoriya commented 5 years ago

Could you give me a logcat with more details please? If you could give me a logcat from the moment you started the app to the moment it crashed in a verbose mode it would be perfect.

Thanks for your feedback, really help to make a better app.

masudr4n4 commented 5 years ago

Sure .Check the detailed logcat below. Logcate.txt Thanks

zoriya commented 5 years ago

I added some debug message, could you update the app and give me another detailed logcat in verbose mode please. I think that I know where the error occurs but I can't figure why an error is thrown here.

zoriya commented 5 years ago

Yeah, I was bussy yesterday and today so I couldn't work at all but I'm on it.

zoriya commented 5 years ago

I added a try/catch block and added debug messages. It should solve the bug but I'm not really sure. This errors seems really weird to me. Will push a new release soon to solve this.

zoriya commented 5 years ago

Ok, I redid the maths and used example and I figured why the app crashed. I was assuming that the width of the image was higher than the height. It's always the case with youtube videos. Now it's solved, thank you for the report!

masudr4n4 commented 5 years ago

When the cool release?Am excited to use

zoriya commented 5 years ago

In the worst case, tomorrow, in the best in 6 hours.

masudr4n4 commented 5 years ago

Oh! I see 3.4.6 version working fine now.

zoriya commented 5 years ago

Nice! Thank for your feedback.