Make Precision field in Widget *json.Number

zorkian / go-datadog-api

A Go implementation of the Datadog API.

BSD 3-Clause "New" or "Revised" License

183 stars 156 forks source link

Make Precision field in Widget *json.Number #194

Closed nyanshak closed 5 years ago

nyanshak commented 5 years ago

Make Precision type for Widget match the type for TileDef.

masci commented 5 years ago

Integration tests are exposing the same problem I have, try running

make testacc TESTARGS='-run=TestWidgets'

nyanshak commented 5 years ago

@masci thanks for pushing on this. I'm not sure I'm satisfied with the changes I just pushed, but they DO pass the tests and handle all the various things that could be returned by Datadog.

@zorkian / @yfronto - mind reviewing this?

masci commented 5 years ago

Provided that it's the API acting weird, this patch looks like a good workaround, it's clean and self-contained. @zorkian any chance to get this merged so I can unblock the TF provider release? Thanks all!